Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for downloading the Game & Watch ROMs #235

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

hallem
Copy link
Contributor

@hallem hallem commented Feb 5, 2024

GlobalHelper:

  • made the ArchiveFiles property populate on first use.
  • added GameAndWatchArchiveFiles

Archive:

  • changed files to be a List<> vs an array so items could be easily removed
  • updated some variable names to camel casing

Config:

  • added new config setting to set the archive name for game and watch

Program:

  • awaited the Global Helper Initialize as it wasn't done populating when testing updating the game and watch core
  • removed commented out code

Core:

  • moved ad hoc string concats to string interpolation
  • removed unused method ReadPlatformFile
  • made Download Asset more generic so it can support downloading the ROMs for Game & Watch
  • added code to download the Game & Watch ROMs from ArchiveOrg
  • made Check CRC more generic so it can support Game & Watch
  • replaced "" with string.Empty
  • collapsed Build Asset Url code into Download Asset to make it easier to be more generic

GlobalHelper:
- made the ArchiveFiles property populate on first use.
- added GameAndWatchArchiveFiles
Archive:
- changed files to be a List<> vs an array so items could be easily removed
- updated some variable names to camel casing
Config:
-added new config setting to set the archive name for game and watch
Program
- awaited the Global Helper Initialize as it wasn't done populating when testing updating the game and watch core
- removed commented out code
Core:
- moved ad hoc string concats to string interpolation
- removed unused method ReadPlatformFile
- made Download Asset more generic so it can support downloading the ROMs for Game & Watch
- added code to download the Game & Watch ROMs from ArchiveOrg
- made Check CRC more generic so it can support Game & Watch
- replaced "" with string.Empty
- collapsed Build Asset Url code into Download Asset to make it easier to be more generic
@mattpannella mattpannella merged commit 99e0405 into mattpannella:main Feb 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants