Blacklist and Image Packs update #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hallem
commented
Feb 9, 2024
hallem
commented
- Added the "bios_1_0_usa.pce" file from the PC Engine CD core alternate file names to the blacklist because it doesn't exist (per discord conversations)
- Added the blacklist check to the alternate file names logic
- Added ifdef statements around both the blacklist and image packs logic to load the JSON files locally when in DEBUG mode
- Added the "bios_1_0_usa.pce" file from the PC Engine CD core alternate file names to the blacklist because it doesn't exist (per discord conversations) - Added the blacklist check to the alternate file names logic - Added ifdef statements around both the blacklist and image packs logic to load the JSON files locally when in DEBUG mode (cherry picked from commit 66568a5)
Comment on lines
+48
to
+50
| #if DEBUG | ||
| string json = await File.ReadAllTextAsync("blacklist.json"); | ||
| #else |
There was a problem hiding this comment.
great idea, simple but useful
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.