Added ability to download the GameBoy Palettes & Pocket Library Images #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Archive Service has what seems to be replicated code, but this is a start to moving some logic off the Core model. No changes to Core were made this time.
brought the instance generator verb inline with the other verbs while preserving existing functionality with the old verb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support was added to download both the GameBoy Palettes from @davewongillies repository and the Pocket Library Images that are on the openFPGA-files archive.
The archive service had new code added to it that slightly replicates functionality in the Core.cs file. This was done intentionally to not increase the dependency on that code. The intent is to migrate code off the models and into services in the future.
Brought the instance generator verb inline with the other verbs while preserving existing functionality with the old verb using an alias.