Pocket Extras Support & Other Stuff #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added menu item for uninstalling one or more of the installed cores - Added menu item for reinstalling one or more of the installed cores - Added a .DotSettings file to ignore some warnings - Little bit of cleanup on Program.cs
Using the enum makes it a lot easier to change the order of the menu items and and/remove menu items.
Ability to download and install Donkey Kong extras from dyrschlock's pocket-extras repo.
The GC was having trouble cleaning up the heap in the hash check method. Assigned the byte arrays to a variable and set that variable to null before it fell out of scope to clue the GC in better.
- Added the Radar Mission and Jotego pocket extras - Fixed the logic to always show the "Requires Beta Access" message during core selection changes - Added second check to make sure the core is installed before trying to install one of the pocket extras - Added missing logic to the RunUpdates when a beta core is skipped because the key is missing - If get random sponsor links doesn't return anything, it no longer writes a blank line
- Added the "bios_1_0_usa.pce" file from the PC Engine CD core alternate file names to the blacklist because it doesn't exist (per discord conversations) - Added the blacklist check to the alternate file names logic - Added ifdef statements around both the blacklist and image packs logic to load the JSON files locally when in DEBUG mode
Turns out only 59 of the cores have sponsor information. So I added logic to the Get Random Sponsor method to only be able to choose from the ones that have that information. Also added logic to the Global Helper to reduce the amount of times it's accessed to once.
stops an error from being thrown if the common directory is missing
- Added support to refresh the local cores list on Global Helper so that's updated when this core is installed - Added the ability to refresh the Status Update event bindings on Pocket Core Updater so the output gets sent to the Console when downloading the assets for the Pocket Extras - Added JSON Ignore to the Pocket Extras core setting so it's not output for every core, only when it's true - Suppressed the Fun Facts messaging when there's nothing to show
refactored a little to reduce the number of times strings were used and to keep them localized to one file.
- combination cores are skipped at the moment - refactored pocket extras code into service to allow for check on core update - corrected asset prefix typo in JSON - removed the unzipped jotego beta key when finished
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other Stuff
( I think that's it...)