Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Camera zoom and focus #2094

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Camera zoom and focus #2094

merged 2 commits into from
Mar 19, 2024

Conversation

aminballoon
Copy link

Feature Zoom, Focus, Tracking was implemented with this repository

@julianoes
Copy link
Collaborator

@aminballoon can you please create the PR for the proto submodule first in https://github.com/mavlink/MAVSDK-Proto?

@aminballoon
Copy link
Author

@julianoes
Copy link
Collaborator

I have not forgotten this one, sorry for the delay.

@julianoes julianoes changed the title Add feature camera to MAVSDK Camera zoom and focus Dec 18, 2023
@julianoes julianoes marked this pull request as draft December 18, 2023 22:23
@aminballoon aminballoon marked this pull request as ready for review January 17, 2024 03:22
@aminballoon
Copy link
Author

@julianoes any update ?

@julianoes
Copy link
Collaborator

Oh dear. Thanks for the reminder!

@julianoes
Copy link
Collaborator

@aminballoon I've rebased this on top of main, changed the proto pull request slightly to how I'd want it, and did a pass through the PR here, mostly following up with renaming a few things.

I've also removed the target_system_id flags which were wrong in my opinion as the target system ID is derived from the System object. Plus, I've removed the "added by PannapatC" as that can be seen by git/github.

@julianoes julianoes force-pushed the main branch 4 times, most recently from 5c7eb2a to 1917ea6 Compare March 18, 2024 23:36
Pannapat Chirathanyanon and others added 2 commits March 19, 2024 13:20
Otherwise, we'll keep running into this depending on include ordering.

Signed-off-by: Julian Oes <[email protected]>
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@julianoes julianoes merged commit 432e4d7 into mavlink:main Mar 19, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants