Updated smart battery example to use non deprecated code #2258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takamasanumuro
changed the title
JonasVautherin
previously approved these changes
Mar 26, 2024
Co-authored-by: Jonas Vautherin <[email protected]>
|
julianoes
requested changes
Mar 27, 2024
|
Original code is not even compiling, it depends on methods which are no longer available. For example, currently Mavsdk type has no parameterized constructor, it does not have a first_autopilot() method, the System class no longer has a value() method, and MavlinkPassthrough no longer has a queue_message() method |
|
You have it backwards. Which MAVSDK version are you compiling against? What have you installed? |
|
It seems I had an old version installed on my system. Sorry. I will close this PR. Thanks. |
|
Ok that makes sense, no worries! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The smart battery example was not working as it depended on code sections of that were deprecated.
The example was updated to use the new available methods and constructors.