Implemented Issue #13 - Add reader mode information to reader object #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-do of pull request #14. Implemented issue #13. Also rebased to master so that it's merge-able. Compiled libmaxminddb locally, compiled maxminddb.extension against it locally, and tested with all modes explicit and with
MODE_AUTO
. Works great!My only concern now is that, in pull request #14, I could access the mode with this:
But now I have to do this:
That's violating best practices by accessing a "private" variable. Suggestions?