Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TypeError: Derived constructors may only return object or undefined #220

Merged
merged 1 commit into from
Jan 12, 2019

Conversation

radum
Copy link
Contributor

@radum radum commented Jan 12, 2019

A class constructor can either return or return an object. If we return true here to exit it will error with TypeError: Derived constructors may only return object or undefined during HMR.

Removing true, and just return will fix this problem.

A class constructor can either return or return an object. If we return true here to exit it will error with `TypeError: Derived constructors may only return object or undefined` during HMR.

Removing true, and just return will fix this problem.
@mbrevda
Copy link
Owner

mbrevda commented Jan 12, 2019

Hmm, this a strange bug - thanks for catching and fixing!

@mbrevda mbrevda merged commit c18712f into mbrevda:master Jan 12, 2019
@radum radum deleted the patch-1 branch January 12, 2019 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants