Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

name_max_len related variables #30

Open
mc12345678 opened this issue Jun 14, 2016 · 0 comments
Open

name_max_len related variables #30

mc12345678 opened this issue Jun 14, 2016 · 0 comments
Labels
enhancement

Comments

@mc12345678
Copy link
Owner

There are several specific variables declared to address the maximum length of characters permitted for the associated variable. Suggest that instead of having X variables that there be 1 variable with X parameters (array). This seems like it will/would make the code more compact and possibly easier to "read" as it were.
mc12345678 added a commit that referenced this issue Feb 14, 2017
@mc12345678
Added export filter to support export of each product one time.
debffec 
- Product now can be exported by master_categories_id such that
the product appears only one time in the export file.  The
category assigned to the product in this export is the category
that is identified as the master category. Fixes #32
- Modified the ep_supported_mods functionality and collection to
compress the overall collection of associated data for supported
modification display.  Existing variables remain in this version;
however, will be deprecated in the future.
- Added additional variable unset commands to continue to minimize
the amount of memory used by EP4.
- Improved custom field usage by ignoring spaces that might exist
in the custom field, began development of incorporating fields
from other tables in the export.
- Generated an array to capture maximum field length instead of
individual variables.  Existing variables remain assigned at
this time, but are to be deprecated in the future. Addresses #30
- Improved the implementation of the update function based on
internal and ZC site version checking to properly implement
the conditions when the Update Database option is presented. Fixes #22.
- Added a check for an empty file to have been uploaded and
associated error message.
- Removed pre-assignment of variables ($chosen_key) that will be assigned
regardless.
- Improved the reporting of the product update to include identifying the
$chosen_key that was used to update or try to update a product during
import. Fixes #25.
- Modified alignment of some code for readability and consistency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mc12345678