Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(zh-cn): remove screenshots from EmbedLiveSample calls (Part 2) #18453

Merged
merged 2 commits into from
Mar 7, 2024

Conversation

yin1999
Copy link
Member

@yin1999 yin1999 commented Mar 7, 2024

Description

remove screenshots from EmbedLiveSample calls (Part 2)

Related issues and pull requests

Upstream: mdn/content#32588

@yin1999 yin1999 requested a review from a team as a code owner March 7, 2024 12:16
@yin1999 yin1999 requested review from jasonren0403 and removed request for a team March 7, 2024 12:16
@github-actions github-actions bot added the l10n-zh Issues related to Chinese content. label Mar 7, 2024
Copy link
Contributor

github-actions bot commented Mar 7, 2024

Preview URLs (9 pages)
Flaws (22)

URL: /zh-CN/docs/Web/API/Canvas_API/Tutorial/Basic_usage
Title: Canvas 的基本用法
Flaw count: 5

  • macros:
    • /zh-CN/docs/Web/API/WindowTimers/setTimeout does not exist but fell back to /en-US/docs/Web/API/setTimeout
    • /zh-CN/docs/Web/API/WindowTimers/setInterval does not exist but fell back to /en-US/docs/Web/API/setInterval
  • broken_links:
    • Can't resolve /zh-CN/docs/Web/WebGL
    • Is currently http:// but can become https://
  • translation_differences:
    • Differences in the important macros (1 in common of 5 possible)

URL: /zh-CN/docs/Web/API/Canvas_API/Tutorial/Drawing_shapes
Title: 使用 canvas 来绘制图形
Flaw count: 3

  • broken_links:
    • Anchor not lowercase
    • Can use the English (en-US) link as a fallback
  • translation_differences:
    • Differences in the important macros (1 in common of 20 possible)

URL: /zh-CN/docs/Web/API/Canvas_API/Tutorial/Using_images
Title: 使用图像
Flaw count: 5

  • macros:
    • /zh-CN/docs/Web/API/CanvasImageSource redirects to /zh-CN/docs/Web/API/CanvasRenderingContext2D
  • broken_links:
    • Is currently http:// but can become https://
    • Can use the English (en-US) link as a fallback
    • Can't resolve /zh-CN/docs/CORS_Enabled_Image#.E4.BB.80.E4.B9.88.E6.98.AF.22.E8.A2.AB.E6.B1.A1.E6.9F.93.22.E7.9A.84canvas
  • translation_differences:
    • Differences in the important macros (1 in common of 9 possible)

URL: /zh-CN/docs/Web/API/CanvasRenderingContext2D/lineCap
Title: CanvasRenderingContext2D.lineCap
Flaw count: 1

  • translation_differences:
    • Differences in the important macros (3 in common of 7 possible)

URL: /zh-CN/docs/Web/API/CanvasRenderingContext2D/fillStyle
Title: CanvasRenderingContext2D.fillStyle
Flaw count: 2

  • macros:
    • wrong xref macro used (consider changing which macro you use)
  • translation_differences:
    • Differences in the important macros (3 in common of 7 possible)

URL: /zh-CN/docs/Web/API/CanvasRenderingContext2D/lineJoin
Title: CanvasRenderingContext2D.lineJoin
Flaw count: 2

  • images:
    • File not present on disk, an empty file, or not an image
  • translation_differences:
    • Differences in the important macros (3 in common of 7 possible)

URL: /zh-CN/docs/Web/API/CanvasRenderingContext2D/strokeStyle
Title: CanvasRenderingContext2D.strokeStyle
Flaw count: 2

  • macros:
    • wrong xref macro used (consider changing which macro you use)
  • translation_differences:
    • Differences in the important macros (3 in common of 7 possible)

URL: /zh-CN/docs/Web/API/CanvasRenderingContext2D/globalAlpha
Title: CanvasRenderingContext2D.globalAlpha
Flaw count: 1

  • translation_differences:
    • Differences in the important macros (3 in common of 7 possible)

URL: /zh-CN/docs/Web/API/CanvasRenderingContext2D/arc
Title: CanvasRenderingContext2D.arc()
Flaw count: 1

  • translation_differences:
    • Differences in the important macros (3 in common of 7 possible)

Copy link
Contributor

@jasonren0403 jasonren0403 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for the cleanup @yin1999 👍

@jasonren0403 jasonren0403 merged commit 10ea7db into mdn:main Mar 7, 2024
7 checks passed
@yin1999 yin1999 deleted the remove-images branch March 7, 2024 22:54
ciyoe pushed a commit to ciyoe/translated-content that referenced this pull request Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-zh Issues related to Chinese content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants