feat(curriculum): add numbers to modules and fixes #10805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caugner
approved these changes
Apr 2, 2024
| @@ -21,7 +29,7 @@ | |||
| } | |||
| } | |||
|
|
|||
| p { | |||
| p.module-topic { | |||
There was a problem hiding this comment.
Nit: Do we need to be this explicit?
Suggested change
| p.module-topic { | |
| .module-topic { |
There was a problem hiding this comment.
No, but we can. That's a discussion for having CSS guidelines in the future.
| @@ -32,6 +40,20 @@ | |||
| content: "Category: "; | |||
| } | |||
| } | |||
|
|
|||
| p.module-group { | |||
There was a problem hiding this comment.
Nit: dito
Suggested change
| p.module-group { | |
| .module-group { |
| @@ -29,7 +29,9 @@ export function ModulesListList({ | |||
| checked={i === tab} | |||
| onChange={() => setTab(i)} | |||
| /> | |||
| <label htmlFor={`module-${i}`}>{modulesList.title}</label> | |||
| <label htmlFor={`module-${i}`}> | |||
| {modulesList.title.replace(/ modules$/, "")} | |||
There was a problem hiding this comment.
Should we have title and short_title, instead of doing these replacements in the view?
There was a problem hiding this comment.
No, that's just for the representation in this specific place for now.
Co-authored-by: Claas Augner <[email protected]>
fiji-flo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on mdn/curriculum#50
Summary
This resolves:
Screenshots
Before/After
How did you test this change?
Locally