Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(stage-build): always build from next + trigger from main #10986

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Apr 24, 2024

Summary

Problem

In #10930, we introduced a ref input for our stage-build workflow to choose the branch to build, but building a branch using the workflow version from another branch is dangerous.

Solution

Remove the ref input again, and always build from next and always trigger from main.


How did you test this change?

Will trigger the stage-build on this branch and it should skip both jobs.

@caugner caugner requested a review from a team as a code owner April 24, 2024 11:07
Copy link
Contributor Author

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-approval.

@caugner caugner merged commit c9fc3de into main Apr 26, 2024
14 checks passed
@caugner caugner deleted the always-build-stage-from-next branch April 26, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant