-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance(toc): localize "In this article" header #11303
Conversation
fr: "Dans cet article", | ||
ja: "この記事では", | ||
ko: "이 문서에서는", | ||
"pt-BR": "Neste artigo", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mdn/yari-content-pt-br Would you mind taking a look if this translation is correct?
PS: Please note that this is a one-off UI localization, and currently we do not accept any community PRs for UI localization.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mdn/yari-content-pt-br Do you have any comments about this translation? 🙏
"en-US": "In this article", | ||
es: "En este artículo", | ||
fr: "Dans cet article", | ||
ja: "この記事では", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mdn/yari-content-ja Would you mind taking a look if this translation is correct?
PS: Please note that this is a one-off UI localization, and currently we do not accept any community PRs for UI localization.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mdn/yari-content-ja Do you have any comments about this translation? 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@caugner
I am noticed this now. I'm sorry for too late reply.
"この記事では" looks odd, and "この記事内" looks better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From ES team, it looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for fr! Sorry for the delay
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for ko. Thanks!
Note: Currently, we do not accept any community PRs for UI localization. Co-authored-by: 1ilsang <[email protected]>
Important
Currently, we do not accept any community PRs for UI localization.
We will revisit UI localization later this year or early next year. Thank you for your understanding!
Summary
(MP-1194)
Problem
Our user interface isn't localized, but some content UI parts should be localized like macros.
Solution
Localize the "In this article" header that is shown above the TOC.
Screenshots
Before
After
How did you test this change?
Ran
yarn dev
and checked http://localhost:3000/fr/docs/Web/HTML locally.