Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(toc): localize "In this article" header #11303

Merged
merged 3 commits into from
Jul 9, 2024

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Jun 12, 2024

Important

Currently, we do not accept any community PRs for UI localization.
We will revisit UI localization later this year or early next year. Thank you for your understanding!

Summary

(MP-1194)

Problem

Our user interface isn't localized, but some content UI parts should be localized like macros.

Solution

Localize the "In this article" header that is shown above the TOC.


Screenshots

Before

image

After

image

How did you test this change?

Ran yarn dev and checked http://localhost:3000/fr/docs/Web/HTML locally.

@caugner caugner requested a review from a team as a code owner June 12, 2024 13:04
fr: "Dans cet article",
ja: "この記事では",
ko: "이 문서에서는",
"pt-BR": "Neste artigo",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdn/yari-content-pt-br Would you mind taking a look if this translation is correct?

PS: Please note that this is a one-off UI localization, and currently we do not accept any community PRs for UI localization.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdn/yari-content-pt-br Do you have any comments about this translation? 🙏

"en-US": "In this article",
es: "En este artículo",
fr: "Dans cet article",
ja: "この記事では",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdn/yari-content-ja Would you mind taking a look if this translation is correct?

PS: Please note that this is a one-off UI localization, and currently we do not accept any community PRs for UI localization.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdn/yari-content-ja Do you have any comments about this translation? 🙏

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@caugner
I am noticed this now. I'm sorry for too late reply.
"この記事では" looks odd, and "この記事内" looks better.

Copy link
Member

@JuanVqz JuanVqz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From ES team, it looks good!

Copy link
Member

@cw118 cw118 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for fr! Sorry for the delay

Copy link
Member

@1ilsang 1ilsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for ko. Thanks!

@caugner caugner merged commit 439736b into main Jul 9, 2024
15 checks passed
@caugner caugner deleted the MP-1194-localize-content-ui branch July 9, 2024 10:10
@caugner caugner restored the MP-1194-localize-content-ui branch July 9, 2024 10:10
@caugner caugner deleted the MP-1194-localize-content-ui branch July 9, 2024 10:10
ferdnyc pushed a commit to ferdnyc/yari that referenced this pull request Jul 13, 2024
Note: Currently, we do not accept any community PRs for UI localization.

Co-authored-by: 1ilsang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants