enhance(bcd): prefix titles with browser name (and version) #12303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caugner
changed the title
|
@jazzygasper Thanks, I pushed some changes to align the changes. Let me know what you think: |
jazzygasper
commented
Feb 13, 2025
| @@ -139,7 +130,7 @@ const CellText = React.memo( | |||
| const added = currentSupport?.version_added ?? null; | |||
| const lastVersion = currentSupport?.version_last ?? null; | |||
|
|
|||
| const browserReleaseDate = getSupportBrowserReleaseDate(support); | |||
| const browserReleaseDate = currentSupport?.release_date; | |||
There was a problem hiding this comment.
Nice and concise! :)
|
@caugner Yep those changes look good to me 🙌 |
caugner
approved these changes
Feb 17, 2025
|
Thank you @jazzygasper! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #10911
Problem
When looking at the compatibility table, especially for pages with long lists, you can't see the browser name when you scroll past the table header.
Solution
Added the browser name and version number to the tooltip in each cell so it says "Full support\nSafari 14.1", instead of just "Full support".
Screenshots
Before
After
How did you test this change?
Checked a page with a long compatibility list eg. http://localhost:3000/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl#browser_compatibility. Hover over tick to check the browser name and version.