ci(stage,prod): skip /static when syncing rest of build #8784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caugner
changed the title
This was referenced May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #8752.
Problem
We're seeing 404s on
/static/js/main.*.jsfor about 10-15 minutes during deployment, because the static assets do not seem to be available when the first updated HTML files are served from the CDN.Solution
Sync the build in three passes:Copy the static assets first (we already do this).Sync the build completely (without deleting extra files).Sync the build again (and delete extra files)Skip
/static(which is copied separately first) when rsyncing the rest of the build (and deleting extra files).How did you test this change?
Will trigger a stage build to see what impact on runtime this has.