Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(csp,fundamental-redirects): replace media.*.mdn.mozit.cloud with mdn.dev #8873

Merged
merged 2 commits into from
May 19, 2023

Conversation

caugner
Copy link
Contributor

@caugner caugner commented May 17, 2023

Summary

(Part of MP-354)

Related:

Problem

We migrated to GCP and archived the legacy media files (including samples) under https://mdn.dev/archives/media/, but we're still redirecting to the old host.

Solution

Update the redirect, and the CSP header.


How did you test this change?

Ran npm start in cloud-function and checked with curl:

% curl localhost:5100/samples/foo
Found. Redirecting to https://mdn.dev/archives/media/samples/foo

@caugner
Copy link
Contributor Author

caugner commented May 17, 2023

Converted to draft due to pending CSP issues.

@caugner caugner marked this pull request as ready for review May 19, 2023 15:29
@caugner caugner requested a review from LeoMcA May 19, 2023 15:38
Copy link
Member

@LeoMcA LeoMcA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@caugner caugner merged commit 2c81bf5 into main May 19, 2023
@caugner caugner deleted the replace-media-mdn-mozit-cloud branch May 19, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants