-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish sass.js compiled with exceptions #23
Comments
I'm not sure what you want me to do here. The Makefile patch already includes |
What I meant is, the bower artifact contains a libsass compiled without exceptions: https://github.com/medialize/sass.js/blob/master/dist/sass.js With that copy (that is also deployed in http://medialize.github.io/sass.js/) when a compilation fails all we get is: Thanks. |
I see what you mean. You're saying that you're not getting the actual error messages as returned by libsass exposed in JS. When compiling invalid scss: Sass.compile(".m { width: $foobar; }"); internally the following error is raised and caught:
externally you get the following error object:
The culprit is within sass.js itself. When originally written, errors were returned in a different format than they are now. Line 148 was responsible for cleaning the error message. An it is now the reason things are failing. What was added originially because I did not fully understand what emscripten was doing with the C++ Exceptions, was now conceiling an error in my own code because libsass changed the syntax of its errors. The is fixed and released as v0.6.3 |
Oh, thanks! I was really mislead by the error plus had the version hardcoded at 0.6.2. |
Hey, could you publish a compiled version of sass.js with exceptions enabled?
Thanks!
The text was updated successfully, but these errors were encountered: