Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix create-validator guide and Add edit-validator guide #121

Merged
merged 4 commits into from
May 26, 2021

Conversation

youngjoon-lee
Copy link
Contributor

  • Fixed wrong option descriptions of the create-validator CLI command.
  • Add a new guide for the edit-validator CLI command.

@youngjoon-lee youngjoon-lee requested review from cl9200 and gyuguen May 24, 2021 14:12
@youngjoon-lee youngjoon-lee changed the title docs: Add a guide for edit-validator docs: Fix create-validator guide and Add edit-validator guide May 24, 2021
Comment on lines +287 to +288
- `min-self-delegation`: A strictly positive integer in `umed` that represents the minimum amount of self-delegated voting power
your validator must always have. If the validator's self-delegated stake falls below this limit, their entire staking pool will unbond.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The unit of min-self-delegation is still unclear. I guess it's a bug of Cosmos SDK: cosmos/cosmos-sdk#9386.

Copy link
Contributor Author

@youngjoon-lee youngjoon-lee May 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well. It was just confirmed by Cosmos team that the unit is umed. cosmos/cosmos-sdk#9386 (comment)

Thus, my change is correct.

Copy link
Contributor

@gyuguen gyuguen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@youngjoon-lee youngjoon-lee merged commit 985271f into master May 26, 2021
@youngjoon-lee youngjoon-lee deleted the docs/na/edit-validator-cli branch May 26, 2021 01:15
@youngjoon-lee youngjoon-lee added this to the v2.0.0 milestone Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants