fix(design-system): singleton prompt #11352
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Skipped Deployments
|
fPolic
requested review from
sradevski,
riqwan,
mrnbpt,
kasperkristensen and
olivermrbl
and removed request for
sradevski and
mrnbpt
| const prompt = async (props: UsePromptProps): Promise<boolean> => { | ||
| if (singleton && flag.current) { |
There was a problem hiding this comment.
LGTM, but should we perhaps just change it so this is the default behaviour, without needing to do singleton: true? I can't really come up with any cases where you would ever want to render multiple prompts since they stack on top of each other, making everyone except the top one visible.
There was a problem hiding this comment.
Yup, makes more sense for this to be the default. Will push a change.
# Conflicts: # packages/admin/dashboard/src/routes/api-key-management/api-key-management-detail/components/api-key-sales-channel-section/api-key-sales-channel-section.tsx
fPolic
changed the title
| let open = true | ||
| if (isPromptActive.current) { | ||
| // If the prompt is already active, return the current promise | ||
| return currentPromptPromise.current! |
There was a problem hiding this comment.
Instead of returning false we return the active promise if prompt is called again while the prompt is already active.
What
Why
CLOSES SUP-802