Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core-flows): add no_notification to fulfillment created event #11507

Merged
merged 2 commits into from
Feb 19, 2025
Merged

fix(core-flows): add no_notification to fulfillment created event #11507

merged 2 commits into from
Feb 19, 2025

Conversation

riqwan
Copy link
Contributor

@riqwan riqwan commented Feb 18, 2025

what:

  • passes no notification toggle to events - fulfillment created and canceled

fixes #11505

@vercel Vercel
Copy link

vercel bot commented Feb 18, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2025 0:44am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Feb 18, 2025 0:44am
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Feb 18, 2025 0:44am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Feb 18, 2025 0:44am
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Feb 18, 2025 0:44am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Feb 18, 2025 0:44am
resources-docs ⬜️ Ignored (Inspect) Visit Preview Feb 18, 2025 0:44am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 18, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: e204035

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@riqwan riqwan marked this pull request as ready for review February 18, 2025 12:43
@riqwan riqwan requested a review from a team as a code owner February 18, 2025 12:43
thetutlage
thetutlage approved these changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@thetutlage thetutlage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kodiakhq kodiakhq bot merged commit 30171f3 into develop Feb 19, 2025
23 checks passed
@kodiakhq kodiakhq bot deleted the fix/no-notification-fulfillment branch February 19, 2025 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thetutlage thetutlage thetutlage approved these changes

@adrien2p adrien2p adrien2p approved these changes

@christiananese christiananese Awaiting requested review from christiananese christiananese is a code owner automatically assigned from medusajs/engineering

@fPolic fPolic Awaiting requested review from fPolic fPolic is a code owner automatically assigned from medusajs/engineering

@kasperkristensen kasperkristensen Awaiting requested review from kasperkristensen kasperkristensen is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
automerge team: medusa type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Notification toggle on order fulfillment/shipping step
4 participants
@riqwan @thetutlage @adrien2p @olivermrbl