chore: Fix CI builds #890
Merged
chore: Fix CI builds #890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing some issues with the build workflow failing at postinstall step. Set correct engine version and don't run postinstall step
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been hitting some weird issue with the build workflow failing at postinstall step.
This is apparently due to the docker user's HOME path being set to
/rootinstead of the home for the usernode.The NPM postinstall step was being run, which somehow was breaking with error code 243, apparently related to permission issues with the cache directory.
See npm/cli#4769
Removing the postinstall step (which is not required and left over from way back when) solves the issue, but some investigation still needs to be done to figure out why the user's home is not set right in the docker image (or if we are using the wrong user somehow).