-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add to google calendar rewrite #148
base: master
Are you sure you want to change the base?
Conversation
…e a temp ics file
…ster calendar or full semester
what does full and current mean here? |
Full : all events (both semestersl |
I have improve on this logic, I want to remove the hard coded mid and end sems date and get them from the academic calendar but need that pr (fetch academic calendar #147 ) to be merged first |
Implement necessary frontend changes as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Add a button to connect with calendar in frontend and integrate with backend.
- Remove the hardcoded dates dependency and parse it from the academic calendar data
- make sure that for a year this will be run twice.. so it doesn't duplicate the holidays and other events from the calendar.
do the first step in this same PR for the remaining 2 steps, make a separate PR |
Rewrite the logic used to add to google calendar.
Now uses the ICS file from generate_ics to insert events into the google calendar
Main benefits :
Google Calendar importing now asks if full calendar is to imported or only the current semester