Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk/node): move js deno to node #539

Merged
merged 26 commits into from
Jan 12, 2024
Merged

Conversation

michael-0acf4
Copy link
Contributor

@michael-0acf4 michael-0acf4 commented Jan 8, 2024

Describe your change

Change deno frontend to pure node

Motivation and context

Easier integration.

Migration notes

Checklist

  • The change come with new or modified tests
  • Hard-to-understand functions have explanatory comments
  • End-user documentation is updated to reflect the change

@michael-0acf4 michael-0acf4 marked this pull request as ready for review January 10, 2024 16:33
Copy link
Member

@zifeo zifeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost done, what about dev/publish, I believe we can safely remove it?

regarding the fact that the deno import using npm:../../ does not work, can you add this a comment and a link to the upstream issue in the index.ts file?

@michael-0acf4
Copy link
Contributor Author

michael-0acf4 commented Jan 11, 2024

almost done, what about dev/publish, I believe we can safely remove it?

regarding the fact that the deno import using npm:../../ does not work, can you add this a comment and a link to the upstream issue in the index.ts file?

yes we can remove dev/publish, the current release step publish directly the dist folder.
https://github.com/metatypedev/metatype/blob/move-js-deno-to-node/.github/workflows/release.yml#L131

Here are some issues on local node project import from deno:
denoland/deno#18701
denoland/deno#18474

Yohe-Am
Yohe-Am previously approved these changes Jan 11, 2024
Copy link
Contributor

@Yohe-Am Yohe-Am left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work.

@michael-0acf4 michael-0acf4 merged commit 12e974f into main Jan 12, 2024
8 checks passed
@michael-0acf4 michael-0acf4 deleted the move-js-deno-to-node branch January 12, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants