Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trac mat add traceability #33

Merged
merged 2 commits into from
Aug 25, 2023
Merged

Trac mat add traceability #33

merged 2 commits into from
Aug 25, 2023

Conversation

barrettk
Copy link
Collaborator

Change add_traceability default per this comment

  • default "auto" - include the trace matrix if an RDS is found (basically same behavior as the mitigation
  • User can also pass
    • TRUE to include. Error if an RDS is not found
    • FALSE don't include (no messages needed)

@barrettk barrettk requested a review from seth127 August 24, 2023 20:32
seth127
seth127 approved these changes Aug 24, 2023
View reviewed changes
Copy link
Collaborator

@seth127 seth127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me. devtools::check() passes for me, and the error case for add_traceability = TRUE works as expected (see below).

Screenshot 2023-08-24 at 4 54 22 PM

@barrettk barrettk merged commit 80a043f into release/0.1.0 Aug 25, 2023
@barrettk barrettk deleted the trac-mat-add_traceability branch August 25, 2023 15:59
barrettk added a commit that referenced this pull request Aug 25, 2023
@barrettk
add minor recursive test for change made in #33
6bc99bc
kyleam pushed a commit that referenced this pull request Sep 13, 2023
@barrettk @kyleam
add minor regression test for change made in #33
22e82d2
@barrettk barrettk mentioned this pull request Oct 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seth127 seth127 seth127 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@barrettk @seth127