Fix encoding of tmp input file #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timkpaine
force-pushed
the
bugfix/fix-tmpfile-encoding
branch
from
b499936 to
84a90f3
Compare
This avoids parsing error due to incorrect encoding in mermaid.js.
timkpaine
force-pushed
the
bugfix/fix-tmpfile-encoding
branch
from
84a90f3 to
21b7d63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When invoking
make latexin a sphinx project, a parsing error may be raised from mermaid.js due to incorrect encoding of temporary filetmpfn. This issue can be reproduced when mermaid diagram contains non-ASCII text (such as Chinese).This PR avoids this kind of parsing error by specifying file encoding as UTF-8 when writing stuff to
tmpfn.