-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] enable ruff-format on some files, add pre-commit config #6308
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me! Thanks for setting this up :)
Co-authored-by: Oliver Borchert <[email protected]>
I think having two |
I don't agree that it's confusing.
I'd prefer to not have a proliferation of tool-specific config files at the root of the repo. And I like having it at the root of the repo so that if you just call However, I feel most strongly about not having the tool-specific config files. So if you don't like having multiple args: ["--config", "python-package/pyproject.toml"] And moving the configuration back into there? |
Yes, I think that's clearer |
Alright no problem, I'm good with that! Just pushed a commit moving the settings back into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This pull request has been automatically locked since there has not been any recent activity since it was closed. |
Contributes to #6304.
ruff format
ruff
linter checks, andisort
into apre-commit
configCONTRIBUTING.md
with information on how to do thatNotes for Reviewers
The versions of tools I added in
.pre-commit-config.yaml
are the latest released versions available.As discussed over in #6304, in this PR I've omitted the directories with a lot of Python code (
examples/
,python-package/
, andtests/
). So we can focus on the types of changes that'll be made and just see a few small examples in other code.Also as described in #6304, I'll add the commit from this PR (and the others that reformat the code) in a
.git-blame-ignore-revs
file once we're done with this work.