Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
'Bug' or 'help wanted' or is in the Community milestone
master
branchjake runtests
locally -- they fail.Description
If
compilerOptions.jsx
isundefined
we treat it like if it wereJSXEmit.React
.I don't feel like this is the right and the most elegant solution and I didn't fix tests yet so this is WIP.
I feel I need some more stepping around the code to find a place to actually set default config values.
Compiler still logs error when JSX flag is not explicitly set.
IMO is not too pretty so I have a fix for it in separate PR (hasparus#1) I'd like to merge into this branch.
Solves #8529