Support the '--help' compiler flag. #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| names: string[], | ||
| isFixed: boolean[]= names.map(() => false), | ||
| isCaseSensitive: boolean = true): string[] { | ||
| export function ensureUniqueness(names: string[], isFixed: boolean[] = names.map(() => false), isCaseSensitive: boolean = false): string[] { |
There was a problem hiding this comment.
This should be left broken down for readability.
There was a problem hiding this comment.
agreed. We also shouldn't be using these default values here. The 'isFixed' in particularly is quite hard to read.
|
👍 |
|
|
||
| // Sort our options by their names, (e.g. "--noImplicitAny" comes before "--watch") | ||
| var optsList = optionDeclarations.slice(); | ||
| optsList.sort((a, b) => compareValues(a.name.toLowerCase(), b.name.toLowerCase())); |
There was a problem hiding this comment.
why a.name.toLowerCase ? that's not needed we would be printing the name as it is so we shouldn't do lowercase on this
There was a problem hiding this comment.
This is just for the sort; we're displaying the names as intended, but our sort is based on case-insensitive lexicographic ordering.
This is ideal because, "sourcemap" should occur before "sourceRoot".
Conflicts: src/compiler/commandLineParser.ts src/compiler/diagnosticInformationMap.generated.ts src/compiler/diagnosticMessages.json
DanielRosenwasser
added a commit
that referenced
this pull request
Aug 6, 2014
Support the '--help' compiler flag.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #269.