-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use separate folder for publishing redist files, not the nuget package cache #4940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can't think of a good reason to publish the entire nuget cache, which adds 4GB and significant time
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
kythant
approved these changes
Dec 7, 2024
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
godlytalias
pushed a commit
that referenced
this pull request
Dec 13, 2024
…e cache (#4940) * Remove publish of packages dir Can't think of a good reason to publish the entire nuget cache, which adds 4GB and significant time * publish redist files exclusively, not the entire nuget package cache * missed redist path * include TAEF in redist * install TEAF from redist folder
codendone
pushed a commit
that referenced
this pull request
Jan 10, 2025
…e cache (#4940) * Remove publish of packages dir Can't think of a good reason to publish the entire nuget cache, which adds 4GB and significant time * publish redist files exclusively, not the entire nuget package cache * missed redist path * include TAEF in redist * install TEAF from redist folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The redist files (DotNet, VCRedist, VCLibs) were being dropped in the local nuget cache folder, packages, resulting in 4GB of unnecessary freight being published and downloaded.