Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use separate folder for publishing redist files, not the nuget package cache #4940

Merged
merged 5 commits into from
Dec 8, 2024

Conversation

Scottj1s
Copy link
Member

@Scottj1s Scottj1s commented Dec 6, 2024

The redist files (DotNet, VCRedist, VCLibs) were being dropped in the local nuget cache folder, packages, resulting in 4GB of unnecessary freight being published and downloaded.

Can't think of a good reason to publish the entire nuget cache, which adds 4GB and significant time
@Scottj1s
Copy link
Member Author

Scottj1s commented Dec 6, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Scottj1s Scottj1s changed the title Remove publish of packages dir Use separate folder for publishing redist files, not the nuget package cache Dec 7, 2024
@Scottj1s
Copy link
Member Author

Scottj1s commented Dec 7, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Scottj1s Scottj1s requested a review from kythant December 7, 2024 00:09
@Scottj1s
Copy link
Member Author

Scottj1s commented Dec 7, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Scottj1s
Copy link
Member Author

Scottj1s commented Dec 7, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Scottj1s
Copy link
Member Author

Scottj1s commented Dec 7, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Scottj1s Scottj1s merged commit 7b78272 into main Dec 8, 2024
26 checks passed
@Scottj1s Scottj1s deleted the user/sjones/remove_packages_publish branch December 8, 2024 05:13
godlytalias pushed a commit that referenced this pull request Dec 13, 2024
…e cache (#4940)

* Remove publish of packages dir

Can't think of a good reason to publish the entire nuget cache, which adds 4GB and significant time

* publish redist files exclusively, not the entire nuget package cache

* missed redist path

* include TAEF in redist

* install TEAF from redist folder
codendone pushed a commit that referenced this pull request Jan 10, 2025
…e cache (#4940)

* Remove publish of packages dir

Can't think of a good reason to publish the entire nuget cache, which adds 4GB and significant time

* publish redist files exclusively, not the entire nuget package cache

* missed redist path

* include TAEF in redist

* install TEAF from redist folder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants