Set target platform for database project from the server metadata #20558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 3011414857
💛 - Coveralls |
kisantia
reviewed
Sep 7, 2022
extensions/sql-database-projects/src/controllers/projectController.ts
Outdated
Show resolved
Hide resolved
| let targetPlatform; | ||
| if (isCloud) { | ||
| const engineEdition = serverInfo.engineEditionId; | ||
| targetPlatform = engineEdition === azdataType.DatabaseEngineEdition.SqlDataWarehouse ? SqlTargetPlatform.sqlDW : (engineEdition === azdataType.DatabaseEngineEdition.SqlDatabase ? SqlTargetPlatform.sqlAzure : undefined); |
There was a problem hiding this comment.
if it isn't DW, can we just assume it's sqlAzure and skip the check if the engineEditoin is SqlDatabase?
There was a problem hiding this comment.
Projects support Sql Edge as well (
). So I thought setting it to SQL Azure wouldn't be completely correct, hence the extra check. But if you think it should safe to skip the additional check, I can do that to.There was a problem hiding this comment.
I think it should be ok to set the target platform to sqlAzure if it's cloud and not DW. @Benjin any concerns with this? I don't think there are that many people creating projects from edge dbs, and the new edge project template creates projects with the target platform 150.
There was a problem hiding this comment.
Updated it for now, waiting on Benjin for confirmation.
kisantia
approved these changes
Sep 8, 2022
|
Created #20576 to track VS code version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #20363.
Currently, all the database projects created from the databases are assigned DSP (target platform) as "Sql Server 2019". instead of its current version. The changes in PR reads the server metadata to determine its version and maps & assigns it appropriately to the target platform for the database project.
Steps to repro:
-- The project should now be created with appropriate target platform.
This PR doesn't handle the VSCode version of Projects.