Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Commit

Permalink
Merge pull request #765 from microsoft/ApiPortIssue764
Browse files Browse the repository at this point in the history
The HyperLinks to About and Privacy docs on Portability Analyzer Setting are not navigatable
  • Loading branch information
Lxiamail authored Jun 12, 2019
2 parents 23c0d67 + 87c9ca4 commit 883066a
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@

<TextBlock Grid.Column="2"
HorizontalAlignment="Right">
<Hyperlink RequestNavigate="NavigateToMoreInformation"
<Hyperlink NavigateUri="DocumentationLinks.About" RequestNavigate="NavigateToMoreInformation"
AutomationProperties.Name="{x:Static const:LocalizedStrings.AboutTool}">
<TextBlock Text="{x:Static const:LocalizedStrings.AboutTool}"
KeyboardNavigation.IsTabStop="True"
Expand All @@ -196,7 +196,7 @@

<TextBlock Grid.Column="4"
HorizontalAlignment="Right">
<Hyperlink RequestNavigate="NavigateToPrivacyModel"
<Hyperlink NavigateUri="DocumentationLinks.PrivacyPolicy" RequestNavigate="NavigateToPrivacyModel"
AutomationProperties.Name="{x:Static const:LocalizedStrings.AboutPrivacy}">
<TextBlock Text="{x:Static const:LocalizedStrings.AboutPrivacy}"
KeyboardNavigation.IsTabStop="True"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ public OptionsPageControl(OptionsViewModel viewModel, IVsStatusbar statusBar)
Unloaded += (s, e) => viewModel.Save();
}

private void NavigateToPrivacyModel(object sender, RequestNavigateEventArgs e) => Process.Start(DocumentationLinks.About.OriginalString);
private void NavigateToPrivacyModel(object sender, RequestNavigateEventArgs e) => Process.Start(DocumentationLinks.PrivacyPolicy.OriginalString);

private void NavigateToMoreInformation(object sender, RequestNavigateEventArgs e) => Process.Start(DocumentationLinks.About.OriginalString);

Expand Down

0 comments on commit 883066a

Please sign in to comment.