-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataGrid] Add IGridSort interface, fixes sorting when using ItemsProvider #3460
Conversation
β¦ed a new 'StaticGridSort' class.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the namespace name and whitespace remarks, think this looks quite good already. π
I don't understand the StaticGridSort purpose. Is it the default IGridSort that gets applied. I don't see it called anywhere (yet?). If it is indeed the default, than I'd suggest to name it like that as well DefaultGridSort
@vnbaaij - Thanks for the feedback! It was late last night when I created this and so I was struggling to come up with a good name for the new class. I'm still not certain that |
Very nice way of solving the issue |
Fixes #3290
Before writing unit tests etc... I wanted to get feedback on whether this would be an acceptable approach.
Pull Request
π Description
π« Issues
π©βπ» Reviewer Notes
π Test Plan
β Checklist
General
Component-specific
β Next Steps