chore(merge-styles): export DeepPartialV2 from index of @fluentui/merge-styles #33806
+14
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gyz0072004
force-pushed
the
master
branch
2 times, most recently
from
18dbf38 to
3edc2f5
Compare
📊 Bundle size report
Unchanged fixtures
|
|
Pull request demo site: URL |
gyz0072004
changed the title
spmonahan
reviewed
Feb 10, 2025
| @@ -7,7 +7,7 @@ export type { IKeyframes } from './IKeyframes'; | |||
| export type { IStyleFunction, IStyleFunctionOrObject } from './IStyleFunction'; | |||
|
|
|||
| // eslint-disable-next-line @typescript-eslint/no-deprecated | |||
| export type { DeepPartial } from './DeepPartial'; | |||
| export type { DeepPartial, DeepPartialV2 } from './DeepPartial'; | |||
There was a problem hiding this comment.
@Hotell WDYT? As I recall you added this type.
There was a problem hiding this comment.
@Hotell Could you please help comment on this? Thanks.
There was a problem hiding this comment.
@spmonahan @Hotell Kindly ping. Is there any further thought on the item?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
The DeepPartialV2 is used in typing of mergeStyles but not exported from index.
New Behavior
export type DeepPartialV2 from index.
Related Issue(s)