Add option to download runner task file #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BMurri
commented
Mar 16, 2024
BMurri
commented
Mar 16, 2024
|
Note to reviewers: I did some drive-by cleanup while I was in some of the code files. |
giventocode
reviewed
Apr 2, 2024
giventocode
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #628
When the new
urlglobal option is specified, its argument is downloaded (to the location specified by thefileoption) before the command proceeds. This is accomplished by intercepting all commands and checking for the new option. If found, a subprocess is created to download the json and thefileoption is refreshed. Then the selected command's handler is called. This redirection is facilitated by the use of hidden "shadow" commands. Ifurlis not specified the net-net is no observable (from the outside) change in behavior.Only for the json download, an environment variable is used to obtain the runtime options and transformation selection for the json download. This enables the runner to use its existing code to obtain SAS tokens for the download without any additional arguments or prepositioned files needed. That environment variable is NOT used for any subsequent operations. This will facilitate using this feature in both the start task and in the work tasks without interference.