-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Release Studio for public publish #1270
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes a more detailed assets.json so the new, more unique URLs are discoverable.
gdams
reviewed
Jul 17, 2024
gdams
approved these changes
Jul 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (other than one newline nit)
Now that the example builds are done, I ran a test release build pipeline against one of them to make sure it'll handle the aka.ms links correctly, and it looks good to me. |
dagood
added a commit
that referenced
this pull request
Jul 18, 2024
Includes a more detailed assets.json so the new, more unique URLs are discoverable. (cherry picked from commit 4997d4d)
dagood
added a commit
that referenced
this pull request
Jul 18, 2024
Includes a more detailed assets.json so the new, more unique URLs are discoverable. (cherry picked from commit 4997d4d)
This was referenced Jul 18, 2024
dagood
added a commit
that referenced
this pull request
Jul 19, 2024
dagood
added a commit
that referenced
this pull request
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes a more detailed assets.json so the new, more unique URLs are discoverable. (Automatic by updating go-infra dependency.)
The pipeline yml is the main difference. This is implemented as a series of stages (send a request -> wait for it to complete -> send a request -> wait for it to complete) by the suggestion of the DDFun team providing us with the NuGet package. This makes it so that we can retry individual stages if the publish request takes an abnormal amount of time and succeeds, but exceeds our stage's timeout. We use a different retry mechanism in microsoft/go-infra, but stage retry makes sense in microsoft/go where we don't have the parameter-driven retry logic of go-infra.
This adds another csproj. Like the signing tooling, the Release Studio tooling is also delivered to us as a .NET NuGet package.
We plan to move this to microsoft/go-infra. Publishing in the release pipelines will allow us to avoid publishing bad builds to an even greater degree than the checkbox being added by this PR. It will also let us use Release Studio's aka.ms link generation capabilities. However, currently the top priority is to get our builds on the CDN that Release Studio is targeting, so this throwaway work is worthwhile.