Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Release Studio for public publish #1270

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Use Release Studio for public publish #1270

merged 2 commits into from
Jul 17, 2024

Conversation

dagood
Copy link
Member

@dagood dagood commented Jul 17, 2024

Includes a more detailed assets.json so the new, more unique URLs are discoverable. (Automatic by updating go-infra dependency.)

The pipeline yml is the main difference. This is implemented as a series of stages (send a request -> wait for it to complete -> send a request -> wait for it to complete) by the suggestion of the DDFun team providing us with the NuGet package. This makes it so that we can retry individual stages if the publish request takes an abnormal amount of time and succeeds, but exceeds our stage's timeout. We use a different retry mechanism in microsoft/go-infra, but stage retry makes sense in microsoft/go where we don't have the parameter-driven retry logic of go-infra.

This adds another csproj. Like the signing tooling, the Release Studio tooling is also delivered to us as a .NET NuGet package.


We plan to move this to microsoft/go-infra. Publishing in the release pipelines will allow us to avoid publishing bad builds to an even greater degree than the checkbox being added by this PR. It will also let us use Release Studio's aka.ms link generation capabilities. However, currently the top priority is to get our builds on the CDN that Release Studio is targeting, so this throwaway work is worthwhile.

Includes a more detailed assets.json so the new,
more unique URLs are discoverable.
@dagood dagood requested a review from a team as a code owner July 17, 2024 19:10
Copy link
Member

@gdams gdams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (other than one newline nit)

@dagood
Copy link
Member Author

dagood commented Jul 17, 2024

Now that the example builds are done, I ran a test release build pipeline against one of them to make sure it'll handle the aka.ms links correctly, and it looks good to me.

@dagood dagood enabled auto-merge (squash) July 17, 2024 21:28
@dagood dagood merged commit 4997d4d into microsoft/main Jul 17, 2024
23 checks passed
@dagood dagood deleted the dev/dagood/rs branch July 17, 2024 22:43
dagood added a commit that referenced this pull request Jul 18, 2024
Includes a more detailed assets.json so the new,
more unique URLs are discoverable.

(cherry picked from commit 4997d4d)
dagood added a commit that referenced this pull request Jul 18, 2024
Includes a more detailed assets.json so the new,
more unique URLs are discoverable.

(cherry picked from commit 4997d4d)
dagood added a commit that referenced this pull request Jul 19, 2024
Includes a more detailed assets.json so the new,
more unique URLs are discoverable.

(cherry picked from commit 4997d4d)
dagood added a commit that referenced this pull request Jul 19, 2024
Includes a more detailed assets.json so the new,
more unique URLs are discoverable.

(cherry picked from commit 4997d4d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants