Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- adds an API key authentication provider #36

Merged
merged 1 commit into from
Oct 24, 2022
Merged

Conversation

baywet
Copy link
Member

@baywet baywet commented Oct 18, 2022

@rkodev
Copy link
Contributor

rkodev commented Oct 24, 2022

@baywet thinking this functionality might be better residing in https://github.com/microsoft/kiota-http-go

@andrueastman
Copy link
Member

Hey @rkodev,
I believe due to the fact that this works by manipulating the RequestInformation abstaction and not http language specific types, it should be okay to keep it here.
If we move this to the HTTP library, this would imply someone using a potential alternative/custom/user-defined http library for Kiota would still need to also pull the http library or re-implement the API key Authentication provider when it actually not really tied to a specific transport mechanism.

@baywet baywet merged commit b5f5ea1 into main Oct 24, 2022
@baywet baywet deleted the feature/key-auth-provider branch October 24, 2022 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants