Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor context object to pass by reference #31

Merged
merged 5 commits into from
Sep 26, 2022
Merged

Conversation

rkodev
Copy link
Contributor

@rkodev rkodev commented Sep 14, 2022

Resolves #30

Adds a method prepareContext that us used to add all the content values to the request context before execution

@baywet
Copy link
Member

baywet commented Sep 14, 2022

Hey @rkodev this is something I noticed while working on #29 and addressed there. Can you run your tests on that PR to double check it addresses everything please? Given the nature of my changes, we'll have a bunch of conflicts if we merge both PRs, and I'll like to avoid that extra work if we can.

@rkodev
Copy link
Contributor Author

rkodev commented Sep 14, 2022

@BayWer this is still failing on the branch, since the context values are still added during getHttpResponseMessage, but we do not receive the context object back. This pr added a single method to set all the parameters from the same point.

I can leave the PR in draft mode till we merge the other PR since it introduces far more changes and would be easier to refactor this one. If the Test work on the othe branch I'm happy to close this one

@baywet
Copy link
Member

baywet commented Sep 14, 2022

that's ok, proceed with this one, and I'll handle the conflicts on mine when I'm ready.
The http PR kind of depends on the abstractions (at least to be feature complete), which depends on this microsoft/kiota#1841

I still have to go through dotnet, java and TS. I don't anticipate other generation changes but they might surface up. And that might take a while during which I'd prefer avoiding blocking you.

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a changelog entry please? patch version

@rkodev rkodev force-pushed the fix/context-by-reference branch from 8069178 to a416cbc Compare September 26, 2022 14:05
@rkodev
Copy link
Contributor Author

rkodev commented Sep 26, 2022

can you add a changelog entry please? patch version

@baywet done

@baywet baywet enabled auto-merge September 26, 2022 14:12
@baywet baywet merged commit 545230b into main Sep 26, 2022
@baywet baywet deleted the fix/context-by-reference branch September 26, 2022 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Response Handler Set Up in Request Context is never Retrieved
2 participants