-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor context object to pass by reference #31
Conversation
@BayWer this is still failing on the branch, since the context values are still added during I can leave the PR in draft mode till we merge the other PR since it introduces far more changes and would be easier to refactor this one. If the Test work on the othe branch I'm happy to close this one |
that's ok, proceed with this one, and I'll handle the conflicts on mine when I'm ready. I still have to go through dotnet, java and TS. I don't anticipate other generation changes but they might surface up. And that might take a while during which I'd prefer avoiding blocking you. |
6b4ff6f
to
4611cd9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add a changelog entry please? patch version
8069178
to
a416cbc
Compare
@baywet done |
Resolves #30
Adds a method
prepareContext
that us used to add all the content values to the request context before execution