Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for tracing #71

Merged
merged 36 commits into from
Sep 27, 2023
Merged

Support for tracing #71

merged 36 commits into from
Sep 27, 2023

Conversation

SilasKenneth
Copy link
Member

No description provided.

@SilasKenneth SilasKenneth self-assigned this Aug 7, 2023
Ndiritu
Ndiritu reviewed Aug 9, 2023
View reviewed changes
Ndiritu
Ndiritu reviewed Aug 9, 2023
View reviewed changes
@SilasKenneth SilasKenneth marked this pull request as ready for review August 31, 2023 06:24
@SilasKenneth SilasKenneth requested a review from Ndiritu August 31, 2023 06:24
musale
musale reviewed Sep 7, 2023
View reviewed changes
musale
musale reviewed Sep 7, 2023
View reviewed changes
musale
musale reviewed Sep 7, 2023
View reviewed changes
musale
musale reviewed Sep 7, 2023
View reviewed changes
@musale
Copy link

musale commented Sep 7, 2023

Good work @SilasKenneth! There are a few missing attributes. Have a look at this https://github.com/microsoftgraph/msgraph-sdk-design/blob/9974f7ed0baa99aeef92d19098bd239696c697db/Observability.md#what-to-capture---tracing for guidance. The base work is well done.

@SilasKenneth
Copy link
Member Author

Hi @musale,
Thanks for the feedback I have addressed all the issues raised.
Kindly recheck the PR.

Ndiritu
Ndiritu requested changes Sep 8, 2023
View reviewed changes
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 11 Code Smells

88.5% 88.5% Coverage
2.8% 2.8% Duplication

musale
musale approved these changes Sep 11, 2023
View reviewed changes
Copy link

@musale musale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@SilasKenneth SilasKenneth merged commit 8a236a0 into dev Sep 27, 2023
@SilasKenneth SilasKenneth deleted the feat/tracing branch September 27, 2023 07:19
@SilasKenneth SilasKenneth mentioned this pull request Oct 4, 2023
Closed
@SilasKenneth SilasKenneth linked an issue Oct 4, 2023 that may be closed by this pull request
tracing support for PHP clients microsoft/kiota#1871
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@musale musale musale approved these changes

@Ndiritu Ndiritu Ndiritu approved these changes

@ddyett ddyett Awaiting requested review from ddyett

@MIchaelMainer MIchaelMainer Awaiting requested review from MIchaelMainer

@nikithauc nikithauc Awaiting requested review from nikithauc

@zengin zengin Awaiting requested review from zengin

@shemogumbe shemogumbe Awaiting requested review from shemogumbe

Assignees

@SilasKenneth SilasKenneth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tracing support for PHP clients
3 participants
@SilasKenneth @musale @Ndiritu