-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
- adds an api key authentication provider #389
Conversation
23edb31
to
703b992
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good! Adding a test for the error throwing behavior would improve our test coverage.
packages/abstractions/test/common/authentication/apiKeyAutenticationProvider.ts
Show resolved
Hide resolved
fast tracking the release as comments were addressed
Oops! I did not observe if auto-merge was set on this PR. |
no worries, I had time to address the comment before you left your review. |
related microsoft/kiota#1902