Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- adds an api key authentication provider #389

Merged
merged 5 commits into from
Oct 28, 2022
Merged

Conversation

baywet
Copy link
Member

@baywet baywet commented Oct 18, 2022

@baywet baywet force-pushed the feature/key-auth-provider branch from 23edb31 to 703b992 Compare October 28, 2022 14:10
@baywet baywet temporarily deployed to build_test October 28, 2022 14:10 Inactive
@baywet baywet temporarily deployed to build_test October 28, 2022 14:10 Inactive
@baywet baywet temporarily deployed to build_test October 28, 2022 14:10 Inactive
Copy link
Contributor

@gavinbarron gavinbarron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good! Adding a test for the error throwing behavior would improve our test coverage.

@baywet baywet temporarily deployed to build_test October 28, 2022 19:51 Inactive
@baywet baywet temporarily deployed to build_test October 28, 2022 19:51 Inactive
@baywet baywet temporarily deployed to build_test October 28, 2022 19:51 Inactive
@baywet baywet requested a review from gavinbarron October 28, 2022 19:51
@baywet baywet dismissed gavinbarron’s stale review October 28, 2022 19:57

fast tracking the release as comments were addressed

@baywet baywet merged commit d82a0f3 into main Oct 28, 2022
@baywet baywet deleted the feature/key-auth-provider branch October 28, 2022 19:57
@nikithauc
Copy link
Contributor

Oops! I did not observe if auto-merge was set on this PR.
I did not intend to override @gavinbarron's comment.

@baywet
Copy link
Member Author

baywet commented Oct 28, 2022

no worries, I had time to address the comment before you left your review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants