Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/observability #427

Merged
merged 15 commits into from
Nov 16, 2022
Merged

feature/observability #427

merged 15 commits into from
Nov 16, 2022

Conversation

baywet
Copy link
Member

@baywet baywet commented Nov 11, 2022

adds tracing support through open telemetry
spec https://github.com/microsoftgraph/msgraph-sdk-design/blob/dm/logging/Observability.md
related microsoft/kiota#618

Had to be put on pause due to other priorities, but I finally got to wrap it up :)

@baywet baywet self-assigned this Nov 11, 2022
@baywet baywet temporarily deployed to build_test November 11, 2022 15:46 Inactive
@baywet baywet temporarily deployed to build_test November 11, 2022 15:46 Inactive
@baywet baywet temporarily deployed to build_test November 11, 2022 15:46 Inactive
@baywet baywet enabled auto-merge November 11, 2022 15:47
@baywet
Copy link
Member Author

baywet commented Nov 11, 2022

I recommend reviewers to check the "hide whitespace changes" option.
This is what a trace looks like in zipkin

image

if you want to try it out (in a node app)

diag.setLogger(new DiagConsoleLogger(), DiagLogLevel.DEBUG);
      const resource =
      Resource.default().merge(
        new Resource({
          [SemanticResourceAttributes.SERVICE_NAME]: "service-name-here",
          [SemanticResourceAttributes.SERVICE_VERSION]: "0.1.0",
        })
      );

    const provider = new NodeTracerProvider({
        resource: resource,
    });
    const exporter = new ZipkinExporter({
    });
    provider.addSpanProcessor(new SimpleSpanProcessor(exporter));
    provider.addSpanProcessor(new SimpleSpanProcessor(new ConsoleSpanExporter()));
    provider.register();

    await trace.getTracer(
      'service-name-here'
    ).startActiveSpan('my-span', async (span) => {
       // do things with the client here
      span.end();
 });

@baywet baywet requested a review from nikithauc November 14, 2022 14:06
@baywet baywet temporarily deployed to build_test November 14, 2022 14:07 Inactive
@baywet baywet temporarily deployed to build_test November 14, 2022 14:07 Inactive
@baywet baywet temporarily deployed to build_test November 14, 2022 14:07 Inactive
@baywet baywet force-pushed the feature/observability branch from ac6226f to c1ae73a Compare November 15, 2022 14:43
@baywet baywet temporarily deployed to build_test November 15, 2022 14:43 Inactive
@baywet baywet temporarily deployed to build_test November 15, 2022 14:43 Inactive
@baywet baywet temporarily deployed to build_test November 15, 2022 14:43 Inactive
 - @microsoft/[email protected]
 - @microsoft/[email protected]
 - @microsoft/[email protected]
 - @microsoft/[email protected]
 - @microsoft/[email protected]
 - @microsoft/[email protected]
@baywet baywet temporarily deployed to build_test November 15, 2022 14:51 Inactive
@baywet baywet temporarily deployed to build_test November 15, 2022 14:51 Inactive
@baywet baywet temporarily deployed to build_test November 15, 2022 14:51 Inactive
nikithauc
nikithauc previously approved these changes Nov 15, 2022
Signed-off-by: Vincent Biret <[email protected]>
@baywet baywet temporarily deployed to build_test November 15, 2022 19:52 Inactive
@baywet baywet temporarily deployed to build_test November 15, 2022 19:52 Inactive
@baywet baywet temporarily deployed to build_test November 15, 2022 19:52 Inactive
@baywet baywet requested a review from nikithauc November 15, 2022 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants