Fix failing serialization tests

microsoft · May 23, 2022 · 569fe8e · 569fe8e
1 parent e940f35
commit 569fe8e
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 27 deletions.
diff --git a/serialization/php/json/composer.json b/serialization/php/json/composer.json
@@ -12,7 +12,10 @@
   "repositories": [
     {
       "type": "path",
-      "url": "../../../abstractions/php"
+      "url": "../../../abstractions/php",
+      "options": {
+        "symlink": false
+      }
     }
   ],
   "autoload": {

diff --git a/serialization/php/json/tests/JsonParseNodeTest.php b/serialization/php/json/tests/JsonParseNodeTest.php
@@ -8,7 +8,6 @@
 use GuzzleHttp\Psr7\Utils;
 use Microsoft\Kiota\Abstractions\Enum;
 use Microsoft\Kiota\Abstractions\Serialization\ParseNode;
-use Microsoft\Kiota\Abstractions\Types\Byte;
 use Microsoft\Kiota\Abstractions\Types\Date;
 use Microsoft\Kiota\Abstractions\Types\Time;
 use Microsoft\Kiota\Serialization\Json\JsonParseNode;
@@ -95,16 +94,6 @@ public function testGetAnyValue(): void {
         $this->assertEquals('Silas Kenneth', $expectedString);
     }
 
-    public function testGetByteValue(): void {
-        $this->parseNode = new JsonParseNode('23');
-        $expected = $this->parseNode->getByteValue();
-        $this->assertInstanceOf(Byte::class, $expected);
-        $this->assertEquals(23, (string)$expected);
-        $this->expectException(Exception::class);
-        $this->parseNode = new JsonParseNode('-192');
-        $this->parseNode->getByteValue();
-    }
-
     public function testGetEnumValue(): void {
         $this->parseNode = new JsonParseNode('married');
         /** @var Enum $expected */

diff --git a/serialization/php/json/tests/JsonSerializationWriterTest.php b/serialization/php/json/tests/JsonSerializationWriterTest.php
@@ -3,7 +3,6 @@
 namespace Microsoft\Kiota\Serialization\Tests;
 
 use Microsoft\Kiota\Abstractions\Serialization\SerializationWriter;
-use Microsoft\Kiota\Abstractions\Types\Byte;
 use Microsoft\Kiota\Abstractions\Types\Date;
 use Microsoft\Kiota\Abstractions\Types\Time;
 use Microsoft\Kiota\Serialization\Json\JsonSerializationWriter;
@@ -135,9 +134,9 @@ public function testWriteEnumValue(): void{
 
     public function testWriteAnyValue(): void {
         $this->jsonSerializationWriter = new JsonSerializationWriter();
-        $byte = new Byte(23);
-        $this->jsonSerializationWriter->writeAnyValue("to", $byte);
-        $expected = '"to":23';
+        $time = new Time('11:00:00');
+        $this->jsonSerializationWriter->writeAnyValue("created", $time);
+        $expected = '"created":"11:00:00"';
         $actual = $this->jsonSerializationWriter->getSerializedContent()->getContents();
         $this->assertEquals($expected, $actual);
     }
@@ -198,17 +197,6 @@ public function testGetSerializedContent(): void{
         $this->assertEquals($expected, $actual);
     }
 
-    /**
-     */
-    public function testWriteByteValue(): void{
-        $this->jsonSerializationWriter = new JsonSerializationWriter();
-        $byte = new Byte(23);
-        $this->jsonSerializationWriter->writeAnyValue("to", $byte);
-        $expected = '"to":23';
-        $actual = $this->jsonSerializationWriter->getSerializedContent()->getContents();
-        $this->assertEquals($expected, $actual);
-    }
-
     /**
      */
     public function testWriteStringValue(): void {