Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP: Add plain text support #1546

Merged
merged 9 commits into from
May 6, 2022
Merged

PHP: Add plain text support #1546

merged 9 commits into from
May 6, 2022

Conversation

Ndiritu
Copy link
Contributor

@Ndiritu Ndiritu commented May 5, 2022 •
edited
Loading

This PR:

  • Adds a plain text serialization package
  • Adds the text serializers by default to the ApiClient constructor
  • Simplifies writing the serializer method body by updating list of primitive types

Closes #1405

@Ndiritu Ndiritu marked this pull request as draft May 5, 2022 22:36
@Ndiritu Ndiritu marked this pull request as ready for review May 6, 2022 11:18
@Ndiritu Ndiritu requested a review from SilasKenneth May 6, 2022 11:20
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@baywet baywet added the PHP label May 6, 2022
@Ndiritu Ndiritu merged commit 277d460 into main May 6, 2022
@Ndiritu Ndiritu deleted the php/feat-plain-text branch May 6, 2022 18:36
@Ndiritu Ndiritu restored the php/feat-plain-text branch May 6, 2022 18:36
@Ndiritu Ndiritu deleted the php/feat-plain-text branch May 6, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

@andrueastman andrueastman Awaiting requested review from andrueastman

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

@zengin zengin Awaiting requested review from zengin

@MIchaelMainer MIchaelMainer Awaiting requested review from MIchaelMainer

@ddyett ddyett Awaiting requested review from ddyett

@peombwa peombwa Awaiting requested review from peombwa

@nikithauc nikithauc Awaiting requested review from nikithauc

@ramsessanchez ramsessanchez Awaiting requested review from ramsessanchez

@calebkiage calebkiage Awaiting requested review from calebkiage

@SilasKenneth SilasKenneth Awaiting requested review from SilasKenneth

Assignees

@Ndiritu Ndiritu

Labels
PHP
Projects
None yet
Milestone
Complete Graph API Surface support
Development

Successfully merging this pull request may close these issues.

php support for text plain
2 participants
@Ndiritu @baywet