Pylint: Enable redefined-builtin #2507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LiliDeng LGTM. Let's merge it next Monday. |
Ack. |
LiliDeng
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables redefined-builtin check. Python allows redefining built-in methods and classes. This gives a lot of flexibility to the language, but can have unexpected consequences and introduce bugs when done unintentionally. This check fails when a built-in function or class is redefined, protecting against doing this unintentionally.
In some cases the variables could be removed
In others, I attempted to rename the variable
When a new name wasn't clear, I used the standard convention of adding a
_to the end of the name.VSCode rename symbol functionality was used to handle renaming and then manually reviewed.