Pylint: Enable modified-iterating-list #2516
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@squirrelsc , @LiliDeng Any issues with this? |
It touches the core part, we don't have a chance to verify it. |
avylove
force-pushed
the
pylint_6
branch
3 times, most recently
from
1f9a9a2 to
1c2be17
Compare
avylove
force-pushed
the
pylint_6
branch
2 times, most recently
from
d77c2ce to
94d3a98
Compare
avylove
force-pushed
the
pylint_6
branch
2 times, most recently
from
c9c1ff1 to
d4fc9f3
Compare
|
Rebased. This is now 3.5 months old. |
|
Please either test with impacted scenarios or suppress this code to enable the rule. This place is safe, because the iterator is broken out after modified. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifying an iterator while iterating over it can have unexpected behavior.
Enables modified-iterating-list check and fixes code.