Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MenuFlyoutSubItem can be laggy when opening on mouse over #9371

Closed
jeremy-visionaid opened this issue Feb 29, 2024 · 8 comments
Closed

MenuFlyoutSubItem can be laggy when opening on mouse over #9371

jeremy-visionaid opened this issue Feb 29, 2024 · 8 comments
Labels
bug Something isn't working needs-triage Issue needs to be triaged by the area owners

Comments

@jeremy-visionaid
Copy link

Describe the bug

There can sometimes be a significant/noticeable delay when displaying a MenuFlyoutSubItem's MenuFlyoutItems

Steps to reproduce the bug

This is reprodicible in WinUI 3 Gallery:
"Menu & toolbars" -> "MenuFlyout"
Then click "File Options" and hover over "Send to"

Occassionaly this takes a few seconds to display the sub items (not every time, but maybe 1 in every 5)

Originally noticed it in a MAUI app, but it appears to affect all Win UI 3 applications

Expected behavior

Sub items should start animating into view immediately on mouse over

Screenshots

No response

NuGet package version

WinUI 3 - Windows App SDK 1.4.5: 1.4.240411001

Windows version

Windows 11 (22H2): Build 22621

Additional context

No response

@jeremy-visionaid jeremy-visionaid added the bug Something isn't working label Feb 29, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the needs-triage Issue needs to be triaged by the area owners label Feb 29, 2024
Copy link

Hi I'm an AI powered bot that finds similar issues based off the issue title.

Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one. Thank you!

Open similar issues:

Closed similar issues:

Note: You can give me feedback by thumbs upping or thumbs downing this comment.

@jeremy-visionaid jeremy-visionaid changed the title MenuFlyoutSubItem can be laggy MenuFlyoutSubItem can be laggy when opening on mouse over Feb 29, 2024
@jeremy-visionaid
Copy link
Author

#8921 looks pretty similar, but I can't judge if this is really a duplicate or not. This one doesn't appear to be affected by the cursor movement speed.

@kmgallahan
Copy link
Contributor

Possibly same issue as #939 with diagnosis found here: #939 (comment)

@jeremy-visionaid
Copy link
Author

jeremy-visionaid commented Feb 29, 2024

@kmgallahan Oh yup, that's the one! I am running a high refresh rate screen... If I set it back down to 60 Hz then the problem goes away... Not the first time I've seen something like this with WinUI 3. I couldn't even target an app against it previously at all because of refresh rate related perf issues like #7290 / #6031 that made it unsuitable for displaying video etc.

Anyways, #939 is a proposal to change the behaviour on clicking the menu items, and this is explitly calling out the display refresh rate performance issue as a bug... Up to you if you want to close this as a dupe.

@kmgallahan
Copy link
Contributor

@DmitriyKomin There are multiple issues related to this: #939 #8921 #9371, plus other elsewhere like microsoft/terminal#14756, & microsoft/terminal#15545

@bpulliam
Copy link
Contributor

Resolving as a duplicate of #8921

@bpulliam bpulliam closed this as not planned Won't fix, can't repro, duplicate, stale Feb 29, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot removed the needs-triage Issue needs to be triaged by the area owners label Feb 29, 2024
@gegao18 gegao18 reopened this Mar 22, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the needs-triage Issue needs to be triaged by the area owners label Mar 22, 2024
@gegao18
Copy link

gegao18 commented Mar 22, 2024

Update - we have two separate issues here. #939 and #8921 deal with a slight delay when expanding cascading menus with a click. This delay exists regardless of the device.

There is also a problem in the way that WinUI 3 handles its clock that causes major delays on variable refresh rate devices, which can cause multi-second delays in DispatcherTimers firing, which then affects things like menus which wait for those timers. I believe that's what this thread is hitting. We have a fix for this variable refresh rate problem coming in 1.5.2.

@fredemmott
Copy link

@gegao18 that’s great! Any chance of a backport to 1.4? I’m using v1.5 in my master branch, but 1.4 -> 1.5 is a too big of a change for me to put in the existing stable branch of my app

@microsoft-github-policy-service microsoft-github-policy-service bot added the needs-triage Issue needs to be triaged by the area owners label Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-triage Issue needs to be triaged by the area owners
Projects
None yet
Development

No branches or pull requests

5 participants