Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WinUI to use HybridCRT #6641

Merged
merged 5 commits into from
Jan 28, 2022
Merged

Update WinUI to use HybridCRT #6641

merged 5 commits into from
Jan 28, 2022

Conversation

kmahone
Copy link
Member

@kmahone kmahone commented Jan 27, 2022

Following an approach from this change in WindowsAppSDK - Use the Universal C Runtime we switch WinUI over to use the HybridCRT.

This removes the dependency on VCLibs for Microsoft.UI.Xaml. VCLibs is still required for most UWP scenarios, but there are Xaml islands scenarios where it is helpful to not have to depend on other framework packages.

I have validates that apps build against this updated Microsoft.UI.Xaml package continue to pass WACK and continue to run correctly on non-desktop skus.

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Jan 27, 2022
@kmahone kmahone requested a review from jevansaks January 27, 2022 17:46
@Scottj1s
Copy link
Member

I assume the WACK questions were all resolved?

@kmahone
Copy link
Member Author

kmahone commented Jan 27, 2022

I assume the WACK questions were all resolved?

Yes. I ran WACK against a build with this change and did not hit any failures.

Copy link
Member

@jevansaks jevansaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you for doing this!

@@ -10,6 +10,12 @@
<PropertyGroup>
<ProjectGuid>{74F24BC4-794D-4CB2-8420-80FF7FDACFE9}</ProjectGuid>
</PropertyGroup>
<ItemGroup>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated change?

@kmahone
Copy link
Member Author

kmahone commented Jan 27, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kmahone kmahone merged commit b2b74e5 into main Jan 28, 2022
@kmahone kmahone deleted the user/kmahone/hybridcrt branch January 28, 2022 17:27
@StephenLPeters StephenLPeters added area-DevInternal Internal build infrastructure, code cleanup, engineering efficiency team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-DevInternal Internal build infrastructure, code cleanup, engineering efficiency team-Controls Issue for the Controls team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants