-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update WinUI to use HybridCRT #6641
Conversation
I assume the WACK questions were all resolved? |
Yes. I ran WACK against a build with this change and did not hit any failures. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you for doing this!
@@ -10,6 +10,12 @@ | |||
<PropertyGroup> | |||
<ProjectGuid>{74F24BC4-794D-4CB2-8420-80FF7FDACFE9}</ProjectGuid> | |||
</PropertyGroup> | |||
<ItemGroup> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated change?
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Following an approach from this change in WindowsAppSDK - Use the Universal C Runtime we switch WinUI over to use the HybridCRT.
This removes the dependency on VCLibs for Microsoft.UI.Xaml. VCLibs is still required for most UWP scenarios, but there are Xaml islands scenarios where it is helpful to not have to depend on other framework packages.
I have validates that apps build against this updated Microsoft.UI.Xaml package continue to pass WACK and continue to run correctly on non-desktop skus.