Fix issue with cancelled touch pointers not resetting state correctly #6875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
roxk
reviewed
Mar 23, 2022
| @@ -1070,7 +1070,8 @@ void NavigationViewItem::ProcessPointerCanceled(const winrt::PointerRoutedEventA | |||
| // What this flag tracks is complicated because of the NavigationView sub items and the m_capturedPointers that are being tracked.. | |||
| // We do this check because PointerCaptureLost can sometimes take the place of PointerReleased events. | |||
| // In these cases we need to test if the pointer is over the item to maintain the proper state. | |||
| if (IsOutOfControlBounds(args.GetCurrentPoint(*this).Position())) | |||
| // In the case of touch input, we want to cancel anyway since there is not pointer exited for touch events. | |||
There was a problem hiding this comment.
From the doc, pointer exited should have been fired for touch as well. Maybe we should just say "we want to cancel anyway".
Or are there 2 code paths that we need to handle, one for cancelling, one for existing?
There was a problem hiding this comment.
Fair point, my comment was not worded entirely correct. So if a pointer is cancelled, in my testing atleast, there won't be a pointer exited. So in the case of touch, we just assume it's gone and we should not stay in the pointer-over mode.
ojhad
added
bug
bpulliam
approved these changes
Dec 2, 2022
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
MartinZikmund
added a commit
to unoplatform/uno
that referenced
this pull request
Sep 5, 2023
… not resetting state correctly microsoft/microsoft-ui-xaml#6875
MartinZikmund
added a commit
to unoplatform/uno
that referenced
this pull request
Sep 18, 2023
… not resetting state correctly microsoft/microsoft-ui-xaml#6875
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a touch pointer gets cancelled, we expect that there still would be a pointer exited event, however that does not occur. Because of that, when we get pointer cancelled for touch pointers, we should treat this also as a pointer-exited event.
Motivation and Context
Fixes #6863
How Has This Been Tested?
Tested manually.
Screenshots (if appropriate):