Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support client certificates #31529

Merged
merged 19 commits into from
Jul 12, 2024
Merged

feat: support client certificates #31529

merged 19 commits into from
Jul 12, 2024

Conversation

mxschmitt
Copy link
Member

@mxschmitt mxschmitt commented Jul 3, 2024 •
edited
Loading

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@mxschmitt mxschmitt force-pushed the client-certificates-api-request-context branch from e64d5f9 to 24339b5 Compare July 3, 2024 10:21
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@mxschmitt mxschmitt force-pushed the client-certificates-api-request-context branch from 24339b5 to 0a3d5dd Compare July 4, 2024 09:07
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@mxschmitt mxschmitt force-pushed the client-certificates-api-request-context branch from 0a3d5dd to 8723c6c Compare July 4, 2024 09:42
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@mxschmitt mxschmitt force-pushed the client-certificates-api-request-context branch from 8723c6c to 5521b11 Compare July 5, 2024 15:15
@mxschmitt mxschmitt marked this pull request as ready for review July 5, 2024 15:28
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
dgozman
dgozman reviewed Jul 8, 2024
View reviewed changes
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@mxschmitt mxschmitt force-pushed the client-certificates-api-request-context branch from 94ad52d to e3ef568 Compare July 10, 2024 07:49
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@mxschmitt mxschmitt force-pushed the client-certificates-api-request-context branch from f6b1532 to cb787be Compare July 10, 2024 20:43
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@Az8th
Copy link
Contributor

Az8th commented Jul 11, 2024

Thanks a lot for adding this feature, it is greatly appreciated :D

dgozman
dgozman reviewed Jul 11, 2024
View reviewed changes
packages/playwright-core/src/server/fetch.ts Outdated
@@ -190,9 +193,11 @@ export abstract class APIRequestContext extends SdkObject {
maxRedirects: params.maxRedirects === 0 ? -1 : params.maxRedirects === undefined ? 20 : params.maxRedirects,
timeout,
deadline,
...(process.env.PW_DO_NOT_USE_EXTRA_CA_CERTS ? { ca: [fs.readFileSync(process.env.PW_DO_NOT_USE_EXTRA_CA_CERTS)] } : {}),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • nit: I'd add an if statement at line 199.5 instead.
  • Should it be PWTEST_CUSTOM_CA? It confusing has "do not use" in the env name, and then uses the ca.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to make the name clear that this is unsupported. Changed it to UNSUPPORTED instead.

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@mxschmitt mxschmitt force-pushed the client-certificates-api-request-context branch from c62b928 to 560f06b Compare July 11, 2024 21:40
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
mxschmitt and others added 2 commits July 12, 2024 10:15
@mxschmitt @dgozman
Apply suggestions from code review
30506af 
Co-authored-by: Dmitry Gozman <[email protected]>
Signed-off-by: Max Schmitt <[email protected]>
@mxschmitt
feedback
eeef444
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@mxschmitt mxschmitt force-pushed the client-certificates-api-request-context branch from 550c500 to 37ab55c Compare July 12, 2024 08:29
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
dgozman
dgozman approved these changes Jul 12, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

Test results for "tests 1"

1 failed
❌ [installation tests] › playwright-electron-should-work.spec.ts:31:5 › electron should work with special characters in path

7 flaky ⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [firefox-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [playwright-test] › ui-mode-test-screencast.spec.ts:21:5 › should show screenshots
⚠️ [webkit-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture

28905 passed, 708 skipped
✔️✔️✔️

Merge workflow run.

@mxschmitt mxschmitt merged commit 9569cb5 into microsoft:main Jul 12, 2024
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgozman dgozman dgozman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mxschmitt @Az8th @dgozman