fix(client-certificates): improve close handling from target and proxy #32158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
force-pushed
the
bugfix/stall-on-tls-errors
branch
from
0eaa54e to
4daf5c2
Compare
mxschmitt
force-pushed
the
bugfix/stall-on-tls-errors
branch
from
0518271 to
2deaedb
Compare
mxschmitt
commented
Aug 14, 2024
packages/playwright-core/src/server/socksClientCertificatesInterceptor.ts
Outdated
Show resolved
Hide resolved
mxschmitt
commented
Aug 14, 2024
packages/playwright-core/src/server/socksClientCertificatesInterceptor.ts
Outdated
Show resolved
Hide resolved
mxschmitt
force-pushed
the
bugfix/stall-on-tls-errors
branch
from
2deaedb to
578dcd6
Compare
mxschmitt
commented
Aug 14, 2024
This comment has been minimized.
This comment has been minimized.
mxschmitt
force-pushed
the
bugfix/stall-on-tls-errors
branch
from
578dcd6 to
198665e
Compare
This comment has been minimized.
This comment has been minimized.
mxschmitt
force-pushed
the
bugfix/stall-on-tls-errors
branch
2 times, most recently
from
955897e to
0a87a88
Compare
This comment has been minimized.
This comment has been minimized.
dgozman
reviewed
Aug 14, 2024
packages/playwright-core/src/server/socksClientCertificatesInterceptor.ts
Outdated
Show resolved
Hide resolved
packages/playwright-core/src/server/socksClientCertificatesInterceptor.ts
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
mxschmitt
force-pushed
the
bugfix/stall-on-tls-errors
branch
from
2a25e86 to
d02577e
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
mxschmitt
added a commit
that referenced
this pull request
Aug 15, 2024
mxschmitt
force-pushed
the
bugfix/stall-on-tls-errors
branch
from
d02577e to
75eb4c1
Compare
mxschmitt
changed the title
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
dgozman
approved these changes
Aug 15, 2024
packages/playwright-core/src/server/socksClientCertificatesInterceptor.ts
Outdated
Show resolved
Hide resolved
…erceptor.ts Co-authored-by: Dmitry Gozman <[email protected]> Signed-off-by: Max Schmitt <[email protected]>
mxschmitt
added a commit
that referenced
this pull request
Aug 15, 2024
… errors Extracted from #32158.
Test results for "tests 1"30006 passed, 860 skipped Merge workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: TLS handshake errors were not reported correctly to the client. Before e.g. during ALPNCache.get neither catch/then was called which lead to stalling connections. This fixes it by adding the appropriate listeners and reporting it back to the client.
#32004