Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(toMatchAriaSnapshot): fail test run when updating missing snapshot #34556

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

dgozman
Copy link
Contributor

@dgozman dgozman commented Jan 30, 2025

No description provided.

This comment has been minimized.

@dgozman dgozman force-pushed the fix-update-aria-fail-on-missing branch from c5df8a7 to 27f9582 Compare January 30, 2025 16:18
Copy link
Contributor

Test results for "tests 1"

17 failed
❌ [webkit-library] › tests/library/browsercontext-viewport-mobile.spec.ts:206:5 › mobile viewport › view scale should reset after navigation @webkit-ubuntu-22.04-node18
❌ [webkit-library] › tests/library/headful.spec.ts:24:3 › should have default url when launching browser @smoke @webkit-ubuntu-22.04-node18
❌ [webkit-library] › tests/library/headful.spec.ts:30:3 › should close browser with beforeunload page @webkit-ubuntu-22.04-node18
❌ [webkit-library] › tests/library/headful.spec.ts:42:3 › should close browsercontext with pending beforeunload dialog @webkit-ubuntu-22.04-node18
❌ [webkit-library] › tests/library/headful.spec.ts:56:3 › should not crash when creating second context @webkit-ubuntu-22.04-node18
❌ [webkit-library] › tests/library/headful.spec.ts:69:3 › should click when viewport size is larger than screen @webkit-ubuntu-22.04-node18
❌ [webkit-library] › tests/library/headful.spec.ts:84:3 › should dispatch click events to oversized viewports @webkit-ubuntu-22.04-node18
❌ [webkit-library] › tests/library/headful.spec.ts:108:3 › should click background tab @webkit-ubuntu-22.04-node18
❌ [webkit-library] › tests/library/headful.spec.ts:114:3 › should close browser after context menu was triggered @webkit-ubuntu-22.04-node18
❌ [webkit-library] › tests/library/headful.spec.ts:122:3 › should(not) block third party cookies @webkit-ubuntu-22.04-node18
❌ [webkit-library] › tests/library/headful.spec.ts:158:3 › should not block third party SameSite=None cookies @webkit-ubuntu-22.04-node18
❌ [webkit-library] › tests/library/headful.spec.ts:195:3 › should not override viewport size when passed null @webkit-ubuntu-22.04-node18
❌ [webkit-library] › tests/library/headful.spec.ts:213:3 › Page.bringToFront should work @webkit-ubuntu-22.04-node18
❌ [webkit-library] › tests/library/headful.spec.ts:233:3 › should click in OOPIF @webkit-ubuntu-22.04-node18
❌ [webkit-library] › tests/library/headful.spec.ts:252:3 › should click bottom row w/ infobar in OOPIF @webkit-ubuntu-22.04-node18
❌ [webkit-library] › tests/library/headful.spec.ts:287:3 › headless and headful should use same default fonts @webkit-ubuntu-22.04-node18
❌ [webkit-library] › tests/library/headful.spec.ts:317:3 › should have the same hyphen rendering on headless and headed @webkit-ubuntu-22.04-node18

33 flaky ⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/browsercontext-clearcookies.spec.ts:92:3 › should remove cookies by domain @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/browsercontext-har.spec.ts:471:3 › should update har.zip for page with different options @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/browsercontext-pages.spec.ts:105:3 › should return bounding box with page scale @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/browsercontext-viewport-mobile.spec.ts:157:5 › mobile viewport › mouse should work with mobile viewports and cross process navigations @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/browsercontext-viewport-mobile.spec.ts:175:5 › mobile viewport › should scroll when emulating a mobile viewport @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:667:7 › cli codegen › should consume contextmenu events, despite a custom context menu @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/popup.spec.ts:129:3 › should use viewport size from window features @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/screenshot.spec.ts:66:14 › page screenshot › should work with a mobile viewport and fullPage @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/screenshot.spec.ts:206:14 › element screenshot › element screenshot should work with a mobile viewport @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/screenshot.spec.ts:291:14 › element screenshot › should restore viewport after page screenshot and timeout @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/selector-generator.spec.ts:68:5 › selector generator › should generate text for @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/selector-generator.spec.ts:73:5 › selector generator › should trim text @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/selector-generator.spec.ts:121:5 › selector generator › should not use text for select @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/selector-generator.spec.ts:129:5 › selector generator › should use ordinal for identical nodes @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/selector-generator.spec.ts:362:5 › selector generator › should match in deep shadow dom @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/selector-generator.spec.ts:467:5 › selector generator › should generate label selector @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:90:1 › should show empty trace viewer @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:237:1 › should contain action info @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:293:1 › should show params and return value @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:399:1 › should show font preview @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:1087:1 › should not crash with broken locator @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:1120:1 › should display waitForLoadState even if did not wait for it @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:1146:1 › should pick locator @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:1336:1 › should highlight locator in iframe while typing @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:1391:1 › should preserve noscript when javascript is disabled @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/video.spec.ts:411:5 › screencast › should capture css transformation @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/video.spec.ts:441:5 › screencast › should work for popups @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-leaks.spec.ts:82:5 › click should not leak @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-leaks.spec.ts:107:5 › fill should not leak @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-leaks.spec.ts:161:5 › waitFor should not leak @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-screenshot.spec.ts:868:5 › page screenshot animations › should wait for fonts to load @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-set-input-files.spec.ts:205:3 › should upload multiple large files @webkit-ubuntu-22.04-node18

37689 passed, 652 skipped
✔️✔️✔️

Merge workflow run.

@dgozman dgozman merged commit ab62ef2 into microsoft:main Jan 30, 2025
27 of 29 checks passed
dgozman added a commit to dgozman/playwright that referenced this pull request Jan 30, 2025
dgozman added a commit that referenced this pull request Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants